feat: add FillIDs feature gate #4075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4075 +/- ##
=======================================
+ Coverage 59.9% 60.0% +0.1%
=======================================
Files 149 149
Lines 16517 16536 +19
=======================================
+ Hits 9896 9937 +41
+ Misses 5992 5969 -23
- Partials 629 630 +1
☔ View full report in Codecov by Sentry. |
randmonkey
previously approved these changes
May 25, 2023
randmonkey
reviewed
May 25, 2023
pmalek
reviewed
May 25, 2023
czeslavo
changed the title
|
E2E (targeted) tests were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5081851172 |
pmalek
approved these changes
May 25, 2023
pmalek
reviewed
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a default-off
FillIDsfeature gate to allow opting in for the #3906.Which issue this PR fixes:
Closes #4074
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR